-
Notifications
You must be signed in to change notification settings - Fork 17.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to prevent spamming Tuning Error messsages when not actually tuning or desired #18609
Conversation
@@ -49,7 +49,7 @@ const AP_Param::GroupInfo AP_Tuning::var_info[] = { | |||
|
|||
// @Param: ERR_THRESH | |||
// @DisplayName: Controller error threshold | |||
// @Description: This sets the controller error threshold above which an alarm will sound and a message will be sent to the GCS to warn of controller instability | |||
// @Description: This sets the controller error threshold above which an alarm will sound and a message will be sent to the GCS to warn of controller instability while tuning. The error is the rms value of the P+D corrections in the loop. High values in hover indicate possible instability due to too high PID gains or excessively high D to P gain ratios.-1 will disable this message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really sound an alarm?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not know...dont have buzzers on my planes....
lgtm, @rmackay9 can you merge? |
AP_Tuning is not used by Copter so no problem for me, merged! |
Prevents spamming tuning error messages if not actually actively tuning with TX tuning
Allows disabling messages entirely by setting error threshold to -1
Added metadata explanation of what message really means
and a drive-by bug fix to the rms calculations for Pitch pids that has been there since 2016